Revert "main: Drop deprecated container-encapsulate entrypoint"
#4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d07002. It turns out that this is used by osbuild today https://github.com/osbuild/osbuild/blob/14d31633a4b14878735ed5222befb895b16de2d1/stages/org.osbuild.ostree.encapsulate#L112 We'll do a patch to port to the new API there but let's just carry this for $time where values of $time are probably at least a year.
cgwalters
added a commit
to cgwalters/osbuild
that referenced
this pull request
Aug 4, 2023
We have a lot of copypasta of `def ostree()` but in this case it's actually rpm-ostree, and we should be clear about that. (Also in the future this code will need to change to use the non-deprecated entrypoint, see coreos/rpm-ostree#4527 )
ondrejbudai
pushed a commit
to cgwalters/osbuild
that referenced
this pull request
Aug 5, 2023
We have a lot of copypasta of `def ostree()` but in this case it's actually rpm-ostree, and we should be clear about that. (Also in the future this code will need to change to use the non-deprecated entrypoint, see coreos/rpm-ostree#4527 )
supakeen
pushed a commit
to cgwalters/osbuild
that referenced
this pull request
Aug 5, 2023
We have a lot of copypasta of `def ostree()` but in this case it's actually rpm-ostree, and we should be clear about that. (Also in the future this code will need to change to use the non-deprecated entrypoint, see coreos/rpm-ostree#4527 )
supakeen
pushed a commit
to osbuild/osbuild
that referenced
this pull request
Aug 5, 2023
We have a lot of copypasta of `def ostree()` but in this case it's actually rpm-ostree, and we should be clear about that. (Also in the future this code will need to change to use the non-deprecated entrypoint, see coreos/rpm-ostree#4527 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2d07002.
It turns out that this is used by osbuild today
https://github.com/osbuild/osbuild/blob/14d31633a4b14878735ed5222befb895b16de2d1/stages/org.osbuild.ostree.encapsulate#L112
We'll do a patch to port to the new API there but let's just carry this for $time where values of $time are probably at least a year.